feat: integrate iOS credential autofill#21
Open
kylebeee wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Integrates iOS passkey AutoFill/Credential Provider support into Rocca by adding iOS configuration (associated domains + entitlements) and synchronizing native-stored credentials into the app’s passkey store during bootstrap/resume, while also tightening bootstrap concurrency to avoid overlapping biometric prompts.
Changes:
- Add iOS AutoFill configuration (associated domains, entitlements) and make passkey AutoFill site/label configurable via env/app config.
- Sync native-stored passkey credentials into
passkeysStoreduring bootstrap and delete native credentials when passkeys are removed. - Prevent overlapping bootstraps by reusing an in-flight bootstrap promise; simplify Passkeys UI display and update tests accordingly.
Reviewed changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| stores/logs.ts | Switches logs store to use @tanstack/store Store. |
| README.md | Adds a note about dependency/publishing requirements for the iOS AutoFill integration. |
| package.json | Bumps/pins @algorandfoundation/react-native-passkey-autofill to 1.0.0-canary.16. |
| package-lock.json | Locks updated dependency versions for passkey autofill + transitive deps. |
| lib/credentialProvider.ts | Adjusts “credential provider service enabled” logic (Android-specific). |
| lib/bootstrap.ts | Adds native credential sync, derived key setup for native side, and bootstrap de-duping. |
| hooks/useConnection.ts | Updates fetchSecret calls to the new options-based signature. |
| extensions/passkeys-keystore/extension.ts | Deletes native credentials when passkeys are removed. |
| dialogs/DidDocumentModal.tsx | Narrows JSONTree input via explicit casting. |
| app/passkeys.tsx | Simplifies passkey list fields (website + username). |
| app/import.tsx | Updates bootstrap invocation to match new signature. |
| app/_layout.tsx | Triggers bootstrap on app resume (after backgrounding) and on passkey events. |
| app.config.js | Adds iOS associated domains/entitlements and makes AutoFill site/label configurable. |
| tests/CollectionScreens-test.tsx | Updates Passkeys screen test expectations for new UI fields. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1,4 +1,4 @@ | |||
| import { Store } from '@tanstack/react-store'; | |||
| import { Store } from '@tanstack/store'; | |||
Contributor
There was a problem hiding this comment.
correct (I see this change unneeded and should use @tanstack/react-store)
Contributor
|
LGTM functionally, if behavior works as intended on iOS let's get it merged after addressing the minor nit above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dependency
Draft until algorandfoundation/react-native-passkey-autofill#11 is merged, published to npm, and Rocca is updated to depend on that published package version.
Validation